Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logger #392

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Improve logger #392

wants to merge 5 commits into from

Conversation

maier49
Copy link
Contributor

@maier49 maier49 commented Apr 25, 2020

Type: bug / feature

The following has been addressed in the PR:

  • There is a related issue
  • All code has been formatted with prettier
  • Unit or Functional tests are included in the PR
  • schema.json has been updated appopriately

Description:
Changes the build output to report sizes by bundle, and incorporates bundle analysis into the build explicitly rather than as a webpack plugin. Also reports on the largest package depended on for any chunks above 250kB (approximately equivalent to 244KB, the size for which Webpack warns that bundles are too large).

This depends on the changes in dojo/webpack-contrib#263
Related to #299 and #390

@agubler
Copy link
Member

agubler commented Sep 30, 2020

Do you think we should still report static assets like images? that are not included in the chunks?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants