This repository has been archived by the owner on Jul 30, 2018. It is now read-only.
Add Prettier with tslint plugin and precommit hook #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitsonk
approved these changes
Dec 19, 2017
edhager
reviewed
Jan 2, 2018
| M, | ||
| T, | ||
| O | ||
| > { |
There was a problem hiding this comment.
Yeah agreed there are some cases where it's not always actually "prettier" :)
edhager
reviewed
Jan 2, 2018
| data.append(decodeURIComponent(name), decodeURIComponent(value)); | ||
| } | ||
| }); | ||
| text |
There was a problem hiding this comment.
Why did prettier break this out into separate lines but left line 153 alone?
edhager
approved these changes
Jan 2, 2018
|
Thanks @edhager |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
The following has been addressed in the PR:
Description:
Adds support for
Prettierto for code style rules and formatting. Include precommit hook that runs prettier on all.tsfiles and an npm script that runs prettier against the codebase.Related to dojo/meta#206