Initial refactor of todo-mvc-kitchensink #190
Conversation
todo-mvc-kitchensink/package.json
Outdated
| "@dojo/widgets": "^2.0.0-alpha.19", | ||
| "@dojo/widget-core": "2.0.0-alpha.25", | ||
| "@dojo/i18n": "2.0.0-alpha.6", | ||
| "@webcomponents/custom-elements": "^1.0.0-alpha.3", | ||
| "maquette": ">=2.3.7 <=2.4.1", |
There was a problem hiding this comment.
Can you bump this to 2.4.3 please?
| @@ -12,11 +11,19 @@ interface FormInputEvent extends KeyboardEvent { | |||
| target: HTMLInputElement; | |||
| } | |||
|
|
|||
| /* | |||
| onkeyup, | ||
| onblur, | ||
| oninput, | ||
| classes: this.classes(styles.base).get() |
There was a problem hiding this comment.
Removed all references to .get()!
| w(Label, <any> { | ||
| theme, | ||
| label, | ||
| onDoubleClick: todoEdit.bind(this), |
There was a problem hiding this comment.
shouldn't need to bind her anymore.
There was a problem hiding this comment.
Well... if I don't bind it to this wont it get bound to the widget it is on? In this case I want it to run on the parent widget?
There was a problem hiding this comment.
Also, this is going to be deleted once i steal your magic from todo-mvc ☠️
There was a problem hiding this comment.
we bind functions magically in WidgetBase
There was a problem hiding this comment.
they are automatically bound to the enclosing widget for w (it wouldn't make sense to bind it to the widget itself).
https://github.com/dojo/widget-core/blob/master/tests/unit/WidgetBase.ts#L162
There was a problem hiding this comment.
So you should be able to remove all bind(this)'s in render functions
| onInput: this.onInput, | ||
| theme | ||
| }), | ||
| v('div', {}, [ |
There was a problem hiding this comment.
if you have no properties, children can be the second arg (just FYI)
There was a problem hiding this comment.
Removed empty {} where i found them
| } | ||
|
|
||
| return v('ul', { | ||
| classes: this.classes(...classList).get() |
There was a problem hiding this comment.
you can do something like this now also
this.classes(
styles.todoItemList,
todos.length === 0 ? styles.empty : null,
activeView === 'cards' ? styles.cardList : null
)There was a problem hiding this comment.
That. Is. Great. Changed
core/request