Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Prettier with tslint plugin and precommit hook #156

Merged
merged 10 commits into from
Dec 19, 2017

Conversation

agubler
Copy link
Member

@agubler agubler commented Dec 16, 2017

Type: feature

The following has been addressed in the PR:

  • There is a related issue
  • All code matches the style guide
  • Unit or Functional tests are included in the PR

Description:

Adds support for Prettier to for code style rules and formatting. Include precommit hook that runs prettier on all .ts files and an npm script that runs prettier against the codebase.

Related to dojo/meta#206

@codecov
Copy link

codecov bot commented Dec 16, 2017

Codecov Report

Merging #156 into master will increase coverage by 0.09%.
The diff coverage is 84.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #156      +/-   ##
==========================================
+ Coverage   84.98%   85.07%   +0.09%     
==========================================
  Files           1        1              
  Lines         506      516      +10     
  Branches      133      138       +5     
==========================================
+ Hits          430      439       +9     
  Misses         32       32              
- Partials       44       45       +1
Impacted Files Coverage Δ
src/loader.ts 85.07% <84.18%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2388ee6...ed72467. Read the comment docs.

@agubler
Copy link
Member Author

agubler commented Dec 16, 2017

Add section to the README for Prettier usage & update the pull request template.

@agubler agubler requested a review from kitsonk December 19, 2017 08:23
@agubler agubler merged commit dec06f4 into dojo:master Dec 19, 2017
@dylans dylans added this to the beta.5 milestone Dec 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants