Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the tslint prettier plugin #157

Merged
merged 1 commit into from
Jan 17, 2018

Conversation

agubler
Copy link
Member

@agubler agubler commented Jan 5, 2018

Type: feature

The following has been addressed in the PR:

Description:

With the commit hook for formatting typescript files with prettier, having the tslint plugin actually hinders development and basically masks actual linting issues (as people will just ignore the errors until prettier is run or the files are committed).

This change removes the plugin.

References dojo/meta#206

@codecov
Copy link

codecov bot commented Jan 5, 2018

Codecov Report

Merging #157 into master will increase coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #157      +/-   ##
==========================================
+ Coverage   84.88%   85.07%   +0.19%     
==========================================
  Files           1        1              
  Lines         516      516              
  Branches      138      138              
==========================================
+ Hits          438      439       +1     
  Misses         32       32              
+ Partials       46       45       -1
Impacted Files Coverage Δ
src/loader.ts 85.07% <0%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dec06f4...66e3ec0. Read the comment docs.

@agubler agubler merged commit 146674c into dojo:master Jan 17, 2018
@dylans dylans added this to the beta.5 milestone Jan 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants