This repository has been archived by the owner on Jul 30, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 18
Use native Promise if available #21
Comments
I really feel we need to address this before the beta release as it has several performance implications and potentially typing implications. A another note, related to #16 is the My thinking is that we should do the following:
|
This was referenced Oct 4, 2016
rorticus
added a commit
to rorticus/shim
that referenced
this issue
Oct 17, 2016
7 tasks
rorticus
added a commit
to rorticus/shim
that referenced
this issue
Oct 25, 2016
rorticus
added a commit
to rorticus/shim
that referenced
this issue
Oct 25, 2016
rorticus
added a commit
to rorticus/shim
that referenced
this issue
Oct 26, 2016
rorticus
added a commit
to rorticus/shim
that referenced
this issue
Oct 26, 2016
rorticus
added a commit
to rorticus/shim
that referenced
this issue
Oct 26, 2016
kitsonk
pushed a commit
to dojo/core
that referenced
this issue
Oct 28, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Unlike say
Map
, thePromise
shim does not fall back to the nativePromise
if it's available. This means we're not benefiting from unhandled rejections and other promise debugging features in modern debuggers.Currently the shim implements the non-standard
Promise#finally()
. This should be moved toTask
before the nativePromise
can be used.The text was updated successfully, but these errors were encountered: