Skip to content
This repository has been archived by the owner on Jul 30, 2018. It is now read-only.

Supporting async/await with global Promise definition and tests, issu… #64

Merged
merged 4 commits into from
Jan 16, 2017

Conversation

rorticus
Copy link
Contributor

…e #70

Type: feature

Description:

Adding Promise (and updating types) to the global space so you can use async/await. Also includes tests for using third-party (Bluebird) Promise objects.

Used like this...

import 'dojo-shim/Promise';

function longRunningTask() {
    return Promise.resolve(1);
}

async function doThings() {
    var result = await longRunningTask();
    // do something with result
}

Related Issue: dojo/meta#70

Please review this checklist before submitting your PR:

  • There is a related issue
  • All contributors have signed a CLA
  • All code matches the style guide
  • The code passes the CI tests
  • Unit or Functional tests are included in the PR
  • The PR increases or maintains the overall unit test coverage percentage
  • The code is ready to be merged

@dylans dylans added this to the 2017.01 milestone Jan 12, 2017
@codecov-io
Copy link

codecov-io commented Jan 16, 2017

Current coverage is 97.02% (diff: 100%)

Merging #64 into master will increase coverage by <.01%

@@             master        #64   diff @@
==========================================
  Files            30         30          
  Lines          1276       1278     +2   
  Methods          24         24          
  Messages          0          0          
  Branches        248        249     +1   
==========================================
+ Hits           1238       1240     +2   
  Misses           21         21          
  Partials         17         17          

Powered by Codecov. Last update 2b2a332...7da558e

@rorticus rorticus merged commit 9c8e9c2 into dojo:master Jan 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants