This repository has been archived by the owner on Jul 30, 2018. It is now read-only.
Materialize #73
Merged
Materialize #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 100% (diff: 100%)@@ master #73 diff @@
====================================
Files 15 16 +1
Lines 1096 1114 +18
Methods 6 6
Messages 0 0
Branches 185 191 +6
====================================
+ Hits 1096 1114 +18
Misses 0 0
Partials 0 0
|
agubler
reviewed
Dec 15, 2016
| if (update.afterAll.length) { | ||
| target.add(update.afterAll); | ||
| } | ||
| } else { |
| if (updates.length) { | ||
| target.put(updates); | ||
| } | ||
|
|
| trackableQueryStore.add(createData()); | ||
| trackableQueryStore.put(createUpdates()[0]); | ||
|
|
||
| setTimeout(dfd.callback(() => { |
There was a problem hiding this comment.
we can use dojo-core/timing#delay for these scenarios and return the promise instead of using the dfd.callback
agubler
reviewed
Dec 16, 2016
| import * as registerSuite from 'intern!object'; | ||
| import * as assert from 'intern/chai!assert'; | ||
| import * as sinon from 'sinon'; | ||
| import {createData, ItemType, createUpdates} from '../support/createData'; |
agubler
approved these changes
Dec 16, 2016
agubler
pushed a commit
that referenced
this pull request
Dec 16, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
Description:
Provides a simple API for materializing
QueryTransformResults. This builds on the work in #67 so that will need to be merged first. Without anapplyfunction materialize willadd()alladds,put()allupdates, anddelete()alldeletesreceived in theStoreDeltas from the observedQueryTransformResult. It will also add all data in theafterAllproperty of the initial update.It returns a
Handlethat can be destroyed to prevent further updates.Specifying an
applyfunction allows the application of updates to be customized.A lot of the concerns brought up in the original issue would be handled by the developer in the provided
applyfunction.Conflict resolution is one of the targeted uses of the
StoreObservableinterface, so when that is implemented, using a target store that supports it would potentially be part of the solution there.Related Issue: #21
Please review this checklist before submitting your PR: