Skip to content
This repository has been archived by the owner on Jul 30, 2018. It is now read-only.

Add Prettier with tslint plugin and precommit hook #94

Merged
merged 6 commits into from
Dec 19, 2017

Conversation

agubler
Copy link
Member

@agubler agubler commented Dec 17, 2017

Type: feature

The following has been addressed in the PR:

  • There is a related issue
  • All code matches the style guide
  • Unit or Functional tests are included in the PR

Description:

Adds support for Prettier to for code style rules and formatting. Include precommit hook that runs prettier on all .ts files and an npm script that runs prettier against the codebase.

Related to dojo/meta#206

@codecov
Copy link

codecov bot commented Dec 17, 2017

Codecov Report

Merging #94 into master will decrease coverage by 0.28%.
The diff coverage is 96.96%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #94      +/-   ##
=========================================
- Coverage   99.39%   99.1%   -0.29%     
=========================================
  Files          10      10              
  Lines         659     674      +15     
  Branches      181     185       +4     
=========================================
+ Hits          655     668      +13     
- Partials        4       6       +2
Impacted Files Coverage Δ
src/resolvers.ts 100% <ø> (ø) ⬆️
src/support/callListener.ts 100% <100%> (ø) ⬆️
src/support/loadJsdom.ts 100% <100%> (ø) ⬆️
src/harness.ts 99.32% <100%> (ø) ⬆️
src/main.ts 100% <100%> (ø) ⬆️
src/support/d.ts 100% <100%> (ø) ⬆️
src/support/sendEvent.ts 97.22% <100%> (-0.22%) ⬇️
src/support/AssertionError.ts 100% <100%> (ø) ⬆️
src/support/compare.ts 98.59% <95%> (-0.91%) ⬇️
src/support/assertRender.ts 98.57% <96.42%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ef570e...b8e2423. Read the comment docs.

@agubler agubler requested a review from kitsonk December 19, 2017 08:24
@agubler agubler merged commit a6aa3d0 into dojo:master Dec 19, 2017
@dylans dylans added this to the beta.5 milestone Dec 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants