Skip to content
This repository has been archived by the owner on Jul 30, 2018. It is now read-only.

Remove Evented and Destroyable from WidgetBase #761

Merged
merged 2 commits into from
Nov 10, 2017

Conversation

agubler
Copy link
Member

@agubler agubler commented Nov 9, 2017

Type: feature

The following has been addressed in the PR:

  • There is a related issue
  • All code matches the style guide
  • Unit or Functional tests are included in the PR

Description:

Removes Evented and Destroyable from WidgetBase, WidgetBase has been updated to accept an optional invalidate method in the constructor that will be called to propagate invalidation up the widget tree.

Performance Comparison against master:

interactive_results

Memory Usage against master:

interactive_results_and_inbox__3__-_agubler_gmail_com_-_gmail

Related to: #760

src/vdom.ts Outdated
@@ -746,7 +745,7 @@ function updateDom(previous: any, dnode: InternalDNode, projectionOptions: Proje
if (hasRenderChanged(previousRendered, rendered)) {
updateChildren(parentNode, previousRendered, dnode.rendered, instance, projectionOptions);
projectionOptions.afterRenderCallbacks.push(() => {
parentInstance.emit({ type: 'widget-updated' });
parentInstance.nodeHandler.addRoot();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested?

@agubler
Copy link
Member Author

agubler commented Nov 9, 2017

@kitsonk added back attachHandle and covered the code paths

@agubler agubler merged commit 5028842 into dojo:master Nov 10, 2017
@dylans dylans added this to the beta.4 milestone Jan 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants