Skip to content
This repository has been archived by the owner on Jul 30, 2018. It is now read-only.

Custom Element rewrite #864

Merged
merged 19 commits into from
Feb 21, 2018
Merged

Custom Element rewrite #864

merged 19 commits into from
Feb 21, 2018

Conversation

matt-gadd
Copy link
Contributor

@matt-gadd matt-gadd commented Feb 14, 2018

Type: feature

Description:
This is a work in progress complete rewrite of our Custom Elements implementation, mainly to support #809, and in general remove a lot of old cruft. I will add more detail to this description and to the readme, but a quick list of what has changed:

  • only 1 module to actually support custom elements (rather than being spread across 2)
  • removed support for descriptors entirely (the decorator is now the only mechanism that can be used)
  • simplified the format that the decorator puts on to the widget proto
  • removed a lot of the functionals in favour of units
  • supports children and properties on children (introspection and writing from parent like: Custom elements do not have access to the properties of their children #809)
  • can add children post appending the parent
  • supports future functionality for custom elements using a global theme

Currently does not support:

  • an initialisation function in the decorator
  • any kind of attribute transform, attributes can only be string types

@matt-gadd matt-gadd changed the title WIP: Custom Element rewrite Custom Element rewrite Feb 16, 2018
@agubler agubler merged commit 5650651 into dojo:master Feb 21, 2018
@dylans dylans added this to the rc.1 milestone Feb 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants