Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove const keyword when declaring enums #525

Merged
merged 1 commit into from
Mar 19, 2018
Merged

Conversation

agubler
Copy link
Member

@agubler agubler commented Mar 16, 2018

Type: bug

The following has been addressed in the PR:

  • There is a related issue
  • All code matches the style guide
  • Unit or Functional tests are included in the PR

Description:

Removes keyword const from declaring enums.

Resolves #524

@codecov
Copy link

codecov bot commented Mar 16, 2018

Codecov Report

Merging #525 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #525      +/-   ##
=========================================
+ Coverage   97.25%   97.3%   +0.05%     
=========================================
  Files          32      32              
  Lines        2477    2526      +49     
  Branches      642     642              
=========================================
+ Hits         2409    2458      +49     
  Misses          9       9              
  Partials       59      59
Impacted Files Coverage Δ
src/tooltip/index.ts 100% <100%> (ø) ⬆️
src/split-pane/index.ts 92.78% <100%> (+0.23%) ⬆️
src/tab-controller/index.ts 99.1% <100%> (+0.04%) ⬆️
src/common/util.ts 100% <100%> (ø) ⬆️
src/checkbox/index.ts 96.93% <100%> (+0.09%) ⬆️
src/combobox/index.ts 97.71% <100%> (+0.04%) ⬆️
src/slide-pane/index.ts 89.93% <100%> (+0.57%) ⬆️
src/calendar/DatePicker.ts 99.28% <100%> (+0.03%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7278cce...eb14d5d. Read the comment docs.

@dylans dylans added this to the rc.2 milestone Mar 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants