Dialog focus handling #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylans
approved these changes
Apr 30, 2018
Codecov Report
@@ Coverage Diff @@
## master #548 +/- ##
==========================================
+ Coverage 97.31% 97.32% +0.01%
==========================================
Files 32 32
Lines 2530 2546 +16
Branches 642 645 +3
==========================================
+ Hits 2462 2478 +16
Misses 9 9
Partials 59 59
Continue to review full report at Codecov.
|
mwistrand
requested changes
May 1, 2018
src/dialog/index.ts
Outdated
| return; | ||
| } | ||
|
|
||
| let dialogFocus = this.meta(Focus).get('main'); |
There was a problem hiding this comment.
Thanks, and good catch! Before I split it out, it was checking dialogFocus twice, and I must've forgotten to change it afterwards. Fixed now!
mwistrand
approved these changes
May 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: bug
The following has been addressed in the PR:
Description:
Resolves #537
Modal dialogs trap focus, non-modal dialogs close on blur