Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(torii): only retrieve metadata for world #2252

Merged
merged 2 commits into from
Aug 4, 2024
Merged

Conversation

lambda-0x
Copy link
Collaborator

@lambda-0x lambda-0x commented Aug 2, 2024

Summary by CodeRabbit

  • New Features

    • Optimized metadata retrieval process by ensuring it only initiates for relevant resources.
  • Bug Fixes

    • Adjusted control flow to prevent unnecessary metadata retrieval for non-zero resources.

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 70.28%. Comparing base (6480c82) to head (af30a75).
Report is 2 commits behind head on main.

Files Patch % Lines
...rates/torii/core/src/processors/metadata_update.rs 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2252      +/-   ##
==========================================
+ Coverage   70.24%   70.28%   +0.03%     
==========================================
  Files         345      345              
  Lines       45455    45434      -21     
==========================================
+ Hits        31930    31933       +3     
+ Misses      13525    13501      -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lambda-0x lambda-0x marked this pull request as ready for review August 3, 2024 20:07
Copy link

coderabbitai bot commented Aug 3, 2024

Walkthrough

Ohayo, sensei! The updates primarily enhance the control flow in the metadata_update.rs file by introducing a conditional check that triggers metadata retrieval only when the resource variable is zero. This optimization prevents unnecessary task execution, ensuring that the system operates more efficiently by only processing relevant cases. Additionally, the import statements have been updated to include a new type, Zeroable, for better overall functionality.

Changes

Files Change Summary
crates/torii/core/src/processors/metadata_update.rs Introduced a conditional check in the async task spawning logic to only retrieve metadata when resource is zero. Updated the import statement to include Zeroable.

Sequence Diagram(s)

sequenceDiagram
    participant A as Caller
    participant B as Processor
    participant C as MetadataService

    A->>B: Check resource
    alt Resource is zero
        B->>C: Spawn async task to retrieve metadata
        C-->>B: Return metadata
    else Resource is non-zero
        B-->>A: Skip metadata retrieval
    end
Loading

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Collaborator

@Larkooo Larkooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lambda-0x lambda-0x merged commit 9834932 into main Aug 4, 2024
14 of 15 checks passed
@lambda-0x lambda-0x deleted the torii-seed-error branch August 4, 2024 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants