-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(torii): only retrieve metadata for world #2252
Conversation
338be8f
to
5ff2ed0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2252 +/- ##
==========================================
+ Coverage 70.24% 70.28% +0.03%
==========================================
Files 345 345
Lines 45455 45434 -21
==========================================
+ Hits 31930 31933 +3
+ Misses 13525 13501 -24 ☔ View full report in Codecov by Sentry. |
WalkthroughOhayo, sensei! The updates primarily enhance the control flow in the Changes
Sequence Diagram(s)sequenceDiagram
participant A as Caller
participant B as Processor
participant C as MetadataService
A->>B: Check resource
alt Resource is zero
B->>C: Spawn async task to retrieve metadata
C-->>B: Return metadata
else Resource is non-zero
B-->>A: Skip metadata retrieval
end
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Summary by CodeRabbit
New Features
Bug Fixes