Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update migration error message about world_address in Scarb.toml #2286

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

remybar
Copy link
Contributor

@remybar remybar commented Aug 12, 2024

Now, the world_address parameter is stored in dojo_<PROFILE_NAME>.toml.

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.87%. Comparing base (0bf090c) to head (9530102).

Files Patch % Lines
crates/sozo/ops/src/migration/mod.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2286   +/-   ##
=======================================
  Coverage   69.87%   69.87%           
=======================================
  Files         352      352           
  Lines       45546    45546           
=======================================
+ Hits        31823    31825    +2     
+ Misses      13723    13721    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@glihm glihm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks good catch man. 👍

@glihm glihm merged commit cb8cf83 into dojoengine:main Aug 12, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants