refactor(torii-libp2p): use is_valid_signature for different sig impls

[Larkooo]

controller signatures are different from signatures from like argent, openzeppelin etc.. so we directly use the account's is_valid_signature function to check the signature validity

Summary by CodeRabbit

• New Features

  • Simplified signature validation process by directly checking signatures, enhancing efficiency.
  • Consolidated the representation of signatures in the Message structure for improved clarity and flexibility.

• Bug Fixes

  • Removed unnecessary error handling related to public key fetching, streamlining control flow during signature validation.

• Documentation

  • Updated the documentation to reflect changes in the Message struct and its signature handling.

[coderabbitai]

Walkthrough

Ohayo, sensei! The recent changes streamline the handling of message signatures in the codebase. The Message struct has been modified to consolidate signature fields into a single vector, enhancing clarity and efficiency. Additionally, the Relay implementation has shifted from fetching public keys to directly validating signatures, improving control flow and reducing complexity. These alterations collectively refine how signatures are processed and validated, fostering better performance and maintainability.

Changes

Files	Change Summary
crates/torii/libp2p/src/server/mod.rs	Replaced getPublicKey with is_valid_signature, simplifying control flow by removing public key retrieval and focusing on direct signature validation.
crates/torii/libp2p/src/tests.rs, crates/torii/libp2p/src/types.rs	Consolidated signature representation in Message struct from signature_r and signature_s to a single signature vector, streamlining data handling.

---

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 0e8239b and 69dff9e.

Files selected for processing (1)

• crates/torii/libp2p/src/tests.rs (1 hunks)

Files skipped from review as they are similar to previous changes (1)

• crates/torii/libp2p/src/tests.rs

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.

Project coverage is 69.61%. Comparing base (00770bd) to head (69dff9e).
Report is 4 commits behind head on main.

Files	Patch %	Lines
crates/torii/libp2p/src/server/mod.rs	0.00%	6 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2302   +/-   ##
=======================================
  Coverage   69.60%   69.61%           
=======================================
  Files         352      352           
  Lines       46031    46018   -13     
=======================================
- Hits        32040    32034    -6     
+ Misses      13991    13984    -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[glihm]

Nice this change for more compatibility across accounts! 👍