fix: ensure models generated Store trait exposes set/update/delete #2348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughOhayo, sensei! The changes involve renaming multiple methods across various files to enhance clarity and reduce ambiguity. Key methods associated with models and entities have been updated to better reflect their purposes, such as changing Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant EntityStoreImpl
participant ModelEntity
participant ModelImpl
User->>EntityStoreImpl: update(entity)
EntityStoreImpl->>ModelEntity: update_entity(entity)
ModelEntity-->>EntityStoreImpl: success
User->>EntityStoreImpl: delete(entity)
EntityStoreImpl->>ModelEntity: delete_entity(entity)
ModelEntity-->>EntityStoreImpl: success
User->>ModelImpl: set(model)
ModelImpl->>Model: set_model(model)
Model-->>ModelImpl: success
User->>ModelImpl: delete(model)
ModelImpl->>Model: delete_model(model)
Model-->>ModelImpl: success
Recent review detailsConfiguration used: .coderabbit.yaml Files selected for processing (1)
Files skipped from review due to trivial changes (1)
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add Documentation and Community
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2348 +/- ##
==========================================
+ Coverage 67.27% 67.51% +0.24%
==========================================
Files 357 359 +2
Lines 46649 46853 +204
==========================================
+ Hits 31383 31634 +251
+ Misses 15266 15219 -47 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to low compiler inference capabilities, the
Storetraits generated forModelandModelEntitywere not including theset,deleteorupdatefunction. Which, in some projects resulted in low devX to use theStoreAPI for models.Summary by CodeRabbit
New Features
Improvements
settoset_model,deletetodelete_model).Bug Fixes
Tests
CaseStoreto the imports in the benchmark tests, allowing for more comprehensive testing scenarios.