-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(torii-relay): remove tls for ws #2361
Conversation
WalkthroughOhayo, sensei! The changes involve the removal of TLS configuration for the WebSocket transport in the Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant Server
Client->>Server: Initiate WebSocket Connection
Server-->>Client: Accept Connection (WS)
Recent review detailsConfiguration used: .coderabbit.yaml Files selected for processing (1)
Additional comments not posted (3)
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2361 +/- ##
==========================================
- Coverage 67.50% 67.49% -0.01%
==========================================
Files 359 359
Lines 46979 46971 -8
==========================================
- Hits 31712 31704 -8
Misses 15267 15267 ☔ View full report in Codecov by Sentry. |
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Note: Users should be aware of the change to a non-secure WebSocket transport, which may impact security considerations.