Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore; use debug for pending tx log #2383

Merged
merged 1 commit into from
Sep 3, 2024
Merged

chore; use debug for pending tx log #2383

merged 1 commit into from
Sep 3, 2024

Conversation

Larkooo
Copy link
Collaborator

@Larkooo Larkooo commented Sep 3, 2024

Summary by CodeRabbit

  • Chores
    • Adjusted logging level for transaction processing messages to improve debugging granularity.

Copy link

coderabbitai bot commented Sep 3, 2024

Walkthrough

Ohayo, sensei! The change involves modifying the logging level of a transaction processing message in the Engine implementation from info to debug. This adjustment affects the visibility of the log output without altering the underlying transaction processing logic.

Changes

Files Change Summary
crates/torii/core/src/engine.rs Changed logging level from info to debug for a specific transaction message.

Sequence Diagram(s)

sequenceDiagram
    participant Engine
    participant Logger

    Engine->>Logger: Log transaction processing message (info)
    Logger-->>Engine: Log output displayed

    Note over Engine: After change

    Engine->>Logger: Log transaction processing message (debug)
    Logger-->>Engine: Log output displayed
Loading

Tip

We have updated our review workflow to use the Anthropic's Claude family of models. Please share any feedback in the discussion post on our Discord.


Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 1d95782 and e19fedc.

Files selected for processing (1)
  • crates/torii/core/src/engine.rs (1 hunks)
Additional comments not posted (1)
crates/torii/core/src/engine.rs (1)

206-206: Ohayo sensei! The log level change looks good to me.

Reducing the verbosity of this log statement from info to debug is a sensible adjustment. It aligns with the purpose of providing more granular visibility for debugging without cluttering the general log output.


Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@glihm
Copy link
Collaborator

glihm commented Sep 3, 2024

@Larkooo this is the only one annoying the logs, or we may have a quick pass on them?

@Larkooo
Copy link
Collaborator Author

Larkooo commented Sep 3, 2024

@Larkooo this is the only one annoying the logs, or we may have a quick pass on them?

This should be main reason the logs fill up quick. As issue with logs only started happening when we enabled index pending to true by default. This is the one that gets spammed on networks like sepolia or mainnet

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.86%. Comparing base (1d95782) to head (e19fedc).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/torii/core/src/engine.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2383   +/-   ##
=======================================
  Coverage   67.86%   67.86%           
=======================================
  Files         359      359           
  Lines       46959    46959           
=======================================
  Hits        31869    31869           
  Misses      15090    15090           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Larkooo Larkooo merged commit 27084a7 into main Sep 3, 2024
14 of 15 checks passed
@Larkooo Larkooo deleted the Larkooo-patch-1 branch September 3, 2024 23:05
kariy pushed a commit to walnuthq/dojo that referenced this pull request Sep 6, 2024
glihm added a commit that referenced this pull request Sep 8, 2024
* feat: add sierra to cairo debug information

* Add walnut flag to sozo execute command

* Pass rpc url to handle_transaction_result

* Add walnut flag to sozo migrate apply command

* Move walnut_debug_transaction to walnut crate

* Cargo fmt

* Keep only one global walnut flag

* Add comments

* Add walnut flag to sozo execute command

* Pass rpc url to handle_transaction_result

* Add walnut flag to sozo migrate apply command

* Move walnut_debug_transaction to walnut crate

* Cargo fmt

* Keep only one global walnut flag

* Add comments

* Resolve conflicts

* Fix lint errors

* Put the walnut crate under the /sozo dir

* Add constants with API and app URLs

* Warn where we fail silently

* Remove unnecessary comments

* Check Walnut API key before migration

* Add doc comments

* Disable walnut flag in auto_authorize

* chore; use debug for pending tx log (#2383)

Update engine.rs

* refactor(katana-rpc): `getEvents` include pending block  (#2375)

* refactor(katana): move predeployedAccounts under DevApi and remove KatanaApi (#2310)

fix: move predeployedAccounts under DevApi and remove KatanaApi

* remove world and indexers table in favour of contracts

commit-id:98359f5f

* opt(torii): batch query execution in sync_range

commit-id:72f22f88

* refactor(torii): make select block cancel safe

commit-id:8fbc8e6d

* opt(torii): use hashmap instead of vector of event processors

commit-id:7303cc72

* opt(torii): fetch receipts along with blocks instead of fetching them individually

commit-id:b6db4cb5

* opt(torii): avoid re-processing of transactions in certain case

fix: #2355

commit-id:a510b985

* wip

* chore(dojo-world): enable manifest feature on `migration` feature

* fmt

* refactor: move walnut config into WalnutDebugger

* fix: ensure only WalnutDebugger is exposed

* fix: restore default dojo_dev.toml

* dont print in library code

* use concrete error types in walnut/verification

* use concrete types again

* remove unecessary util function

* use json method instead

* fix: fix test

---------

Co-authored-by: glihm <[email protected]>
Co-authored-by: Larko <[email protected]>
Co-authored-by: Ammar Arif <[email protected]>
Co-authored-by: lambda-0x <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants