Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump blockifier to v0.8.0-rc3 #2414

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Bump blockifier to v0.8.0-rc3 #2414

merged 1 commit into from
Sep 11, 2024

Conversation

kariy
Copy link
Member

@kariy kariy commented Sep 11, 2024

Migrate Blockifier to using the new dojoengine/sequencer repo

Summary by CodeRabbit

  • New Features

    • Updated dependencies for improved functionality and performance, including enhancements to the virtual machine and integration of a new source for the blockifier library.
  • Bug Fixes

    • Incremented version of the cairo-vm dependency to address potential issues.
  • Refactor

    • Simplified the instantiation process of the StatefulValidator by removing unnecessary parameters.

Copy link

coderabbitai bot commented Sep 11, 2024

Walkthrough

Ohayo, sensei! The pull request introduces updates to the Cargo.toml files for the katana project, modifying dependency versions and sources. The cairo-vm dependency is updated from 1.0.0 to 1.0.1, while the starknet_api and blockifier dependencies are changed to point to specific Git repositories and tags. Additionally, a method call in the StatefulValidator has been adjusted to remove a default parameter. These changes reflect a shift in dependency management and method usage.

Changes

Files Change Summary
crates/katana/cairo/Cargo.toml Updated cairo-vm from 1.0.0 to 1.0.1; changed starknet_api from version string to Git repo with tag.
crates/katana/executor/Cargo.toml Modified blockifier dependency to point to a different Git repo and tag, changing its source and versioning.
crates/katana/pool/src/validation/... Removed default parameter from StatefulValidator::create method call, now passing only two arguments.

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 80d1827 and 7cc9b3a.

Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
Files selected for processing (3)
  • crates/katana/cairo/Cargo.toml (1 hunks)
  • crates/katana/executor/Cargo.toml (1 hunks)
  • crates/katana/pool/src/validation/stateful.rs (1 hunks)
Additional comments not posted (4)
crates/katana/cairo/Cargo.toml (2)

20-20: Ohayo sensei! The cairo-vm version bump looks good to me.

The minor version update from 1.0.0 to 1.0.1 should bring in bug fixes or small enhancements while maintaining compatibility. Nice work!


21-21: Ohayo sensei! The starknet_api dependency update aligns perfectly with the PR objective.

Migrating the starknet_api dependency to reference the dojoengine/sequencer repository at the v0.8.0-rc3 tag ensures that the Blockifier component is updated to work with the latest features and improvements provided by the sequencer. This change reflects the primary goal of the PR. Excellent work, sensei!

crates/katana/executor/Cargo.toml (1)

18-18: Ohayo sensei! The blockifier dependency update looks good, but please verify compatibility.

The blockifier dependency has been updated to point to the sequencer repository with the tag v0.8.0-rc3. This change in the dependency source and version may introduce changes in functionality or API.

Please ensure that:

  1. The new blockifier version is compatible with the project's requirements and doesn't introduce any breaking changes.
  2. Thorough testing is performed to validate the smooth integration of the updated dependency.

If you need any assistance with the verification process or encounter any issues, feel free to reach out!

crates/katana/pool/src/validation/stateful.rs (1)

91-91: Ohayo sensei! Let's verify the reason for removing the default parameter.

The code change suggests a refinement in the StatefulValidator::create method's usage. It may indicate that the default value is no longer necessary or the method has been updated to handle fewer parameters.

To ensure this change is intentional and doesn't introduce any issues, please verify the following:

  1. Confirm that the StatefulValidator::create method no longer requires or accepts the default parameter.
  2. Ensure that removing the default parameter doesn't affect the functionality or correctness of the code.
  3. Verify that this change is consistently applied across the codebase wherever StatefulValidator::create is used.
Verification successful

Ohayo sensei! The change to StatefulValidator::create is verified.

The method no longer requires the Default::default() parameter, and this change is consistently applied across the codebase. There are no occurrences of the method being called with the default parameter, confirming that the update is intentional and does not affect functionality.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the usage of StatefulValidator::create method.

# Test 1: Search for the method definition. Expect: Method signature without the default parameter.
rg --type rust -A 5 $'StatefulValidator::create'

# Test 2: Search for other usages of the method. Expect: No occurrences with the default parameter.
rg --type rust -A 5 $'StatefulValidator::create\(.*Default::default\(\)\)'

Length of output: 543


Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.91%. Comparing base (80d1827) to head (7cc9b3a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2414      +/-   ##
==========================================
- Coverage   67.92%   67.91%   -0.01%     
==========================================
  Files         364      364              
  Lines       47760    47759       -1     
==========================================
- Hits        32440    32435       -5     
- Misses      15320    15324       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kariy kariy merged commit bf4ea9b into main Sep 11, 2024
15 checks passed
@kariy kariy deleted the bump-blockifier branch September 11, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant