fix(torii-grpc): member clause should never error out if no entities

[Larkooo]

Summary by CodeRabbit

• Bug Fixes
  • Improved error handling for model data retrieval, preventing crashes when no results are found.
  • Enhanced application stability by returning an empty vector and count of zero when no data is available.

[coderabbitai]

Walkthrough

Ohayo, sensei! The changes in this pull request update the method for retrieving model data from the database. The previous implementation used fetch_one, which could panic if no results were found. This has been replaced with fetch_optional, allowing the function to return an Option type. If no results are found, it now returns an empty vector and a count of zero, enhancing the application's stability by preventing runtime errors.

Changes

Files	Change Summary
crates/torii/grpc/src/server/mod.rs	Modified data retrieval from the database by replacing fetch_one with fetch_optional to handle empty results gracefully.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant Server
    participant Database

    Client->>Server: Request model data
    Server->>Database: fetch_optional(query)
    alt Result found
        Database-->>Server: Return model data
        Server-->>Client: Send model data
    else No result found
        Database-->>Server: Return None
        Server-->>Client: Send empty vector and count zero
    end

Loading

---

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between eca7f15 and 365af7f.

Files selected for processing (1)

• crates/torii/grpc/src/server/mod.rs (5 hunks)

Files skipped from review as they are similar to previous changes (1)

• crates/torii/grpc/src/server/mod.rs

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 27.77778% with 13 lines in your changes missing coverage. Please review.

Project coverage is 67.90%. Comparing base (bf4ea9b) to head (365af7f).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/torii/grpc/src/server/mod.rs	27.77%	13 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2418      +/-   ##
==========================================
- Coverage   67.92%   67.90%   -0.02%     
==========================================
  Files         364      364              
  Lines       47759    47773      +14     
==========================================
  Hits        32439    32439              
- Misses      15320    15334      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[glihm]

Format and let's add this to ensure Torii doesn't error.

Would have been great to have a test associated to it, maybe done in a subsequent PR. But feeling like we've edge cases being fixed, but not way to ensure no regressions. 👍