Добавляет рецепт контейнера с горизонтальным скроллом и динамическими тенями #5480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
punkmachine
requested review from
skorobaeus,
solarrust,
HellSquirrel and
TatianaFokina
as code owners
|
@solarrust держи демку, как обещал в ишью. Надеюсь кто-то сможет нормально оформить. |
vitya-ne
reviewed
Aug 6, 2024
Comment on lines
113
to
123
| if (scrollLeft > 10) { | ||
| shadowLeft.classList.remove('scroll-shadow__shadow--hide'); | ||
| } else { | ||
| shadowLeft.classList.add('scroll-shadow__shadow--hide'); | ||
| } | ||
|
|
||
| if (scrollLeft < maxScrollLeft - 10) { | ||
| shadowRight.classList.remove('scroll-shadow__shadow--hide'); | ||
| } else { | ||
| shadowRight.classList.add('scroll-shadow__shadow--hide'); | ||
| } |
There was a problem hiding this comment.
можно упростить:
shadowLeft.classList.toggle('scroll-shadow__shadow--hide', scrollLeft <= 10);
shadowRight.classList.toggle('scroll-shadow__shadow--hide', scrollLeft >= maxScrollLeft - 10);
TatianaFokina
changed the title
|
@skorobaeus давай, пожалуйста, докрутим эту демку и тогда я напишу к ней рецепт 🙏 |
|
ПРОСТИТЕ ХРИСТА РАДИ, меня присыпало уведомлениями и я пропустила этот ПР.
Я покрасила и вынесла СВГшную собаку на свет :) |
Превью контента из 81bcfcb опубликовано. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Добавил только демо, чтобы в дальнейшем кто-то смог дописать статью, т.к. не имею времени на оформление текста.
Функционал готов, наверное вам придётся подправить ещё и цвета демо, чтобы смотрелось лучше.
Closes #4299
Чек-лист
/css/color/,/tools/json/,/tools/gulp/#kak-ponyat)images/example.png,demos/example/,../demos/example/)