Remove potential memory leak in DokanCreateDiskDevice on allocation failure (resubmit) #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That is well seen :) ! even code analyser haven't found it! Thank you @canardos again ! |
Liryna
added a commit
that referenced
this pull request
Nov 12, 2015
Remove potential memory leak in DokanCreateDiskDevice on allocation failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing code assumes that if one of
SymbolicLinkNameDiskDeviceNameorFileSystemDeviceNamefails allocation, then the subsequent allocations also failed and does not free them. This may not be the case, resulting in a memory leak.Other failure paths also fail to free these items.
Note: Resubmission of pull 107.