-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependencies prefixed with @types should be in devDependencies #59
Comments
henrikra
changed the title
Dependencies prefixes with @types should be in devDependencies
Dependencies prefixed with @types should be in devDependencies
Jan 8, 2018
Yeah good point I did this because of this:
But in our case, I suppose it doesn't need to be in And stuff like this too: |
Will make a PR |
Great! Should we also change README so that we install only |
Good read here |
Good idea about README |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Only libraries should have types in dependencies. And since this is not library they should in devDependencies :)
The text was updated successfully, but these errors were encountered: