Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies prefixed with @types should be in devDependencies #59

Closed
henrikra opened this issue Jan 8, 2018 · 5 comments
Closed

Dependencies prefixed with @types should be in devDependencies #59

henrikra opened this issue Jan 8, 2018 · 5 comments

Comments

@henrikra
Copy link
Collaborator

henrikra commented Jan 8, 2018

Only libraries should have types in dependencies. And since this is not library they should in devDependencies :)

@henrikra henrikra changed the title Dependencies prefixes with @types should be in devDependencies Dependencies prefixed with @types should be in devDependencies Jan 8, 2018
@dolanmiu
Copy link
Owner

dolanmiu commented Jan 8, 2018

Yeah good point

I did this because of this:

https://stackoverflow.com/questions/45176661/how-do-i-decide-whether-types-goes-into-dependencies-or-devdependencies

you NEED to place @types/* package with regular "dependencies". For other cases "devDependencies" are good enough.

But in our case, I suppose it doesn't need to be in dependencies

And stuff like this too:

apollographql/apollo-client#713

@dolanmiu
Copy link
Owner

dolanmiu commented Jan 8, 2018

Will make a PR

@henrikra
Copy link
Collaborator Author

henrikra commented Jan 8, 2018

Great! Should we also change README so that we install only dependencies with npm install? Only developers of this module need to install dev dependencies too

@dolanmiu
Copy link
Owner

dolanmiu commented Jan 8, 2018

microsoft/types-publisher#81

Good read here

@dolanmiu
Copy link
Owner

dolanmiu commented Jan 8, 2018

Good idea about README

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants