-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider moving @types packages from devDependencies to dependencies #713
Comments
@antmdvs Yeah, that makes sense. Can you make a PR so we can see how much that would add to the gzipped bundle size? |
In theory it shouldn't add anything at all since it wouldn't be bundled. |
@helfer I would love to contribute, but i'm swamped at the moment. I'll check back in a couple days to see if this is still actionable and try to help out then. |
Closed
Ok, I'm looking into this now. |
antmdvs
pushed a commit
to antmdvs/apollo-client
that referenced
this issue
Oct 2, 2016
Closed
stubailo
pushed a commit
that referenced
this issue
Oct 14, 2016
Fixed #713 with OptionalDependencies approach
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The rationale is discussed here:
microsoft/types-publisher#81
This doesn't prevent my app from running, but the TS errors are pretty annoying especially because they break HMR (with the overlay configured) as shown below:
The text was updated successfully, but these errors were encountered: