Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider moving @types packages from devDependencies to dependencies #713

Closed
antmdvs opened this issue Sep 26, 2016 · 4 comments
Closed

Comments

@antmdvs
Copy link

antmdvs commented Sep 26, 2016

The rationale is discussed here:
microsoft/types-publisher#81

This doesn't prevent my app from running, but the TS errors are pretty annoying especially because they break HMR (with the overlay configured) as shown below:

apollo ts declaration dependencies_censored

@helfer
Copy link
Contributor

helfer commented Sep 27, 2016

@antmdvs Yeah, that makes sense. Can you make a PR so we can see how much that would add to the gzipped bundle size?

@stubailo
Copy link
Contributor

In theory it shouldn't add anything at all since it wouldn't be bundled.

@antmdvs
Copy link
Author

antmdvs commented Sep 28, 2016

@helfer I would love to contribute, but i'm swamped at the moment. I'll check back in a couple days to see if this is still actionable and try to help out then.

@antmdvs
Copy link
Author

antmdvs commented Oct 1, 2016

Ok, I'm looking into this now.

antmdvs pushed a commit to antmdvs/apollo-client that referenced this issue Oct 2, 2016
Moved @types packages from devDependencies to dependencies per apollographql#713
@antmdvs antmdvs mentioned this issue Oct 2, 2016
7 tasks
stubailo pushed a commit that referenced this issue Oct 14, 2016
Fixed #713 with OptionalDependencies approach
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants