Export new ColumnBreak class via more generic Break class
#1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perfect, looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only new feature in this PR is the new
ColumnBreakclass. See this spec for more details.I figured it made sense to extend the existing
Breakclass by allowing a break type to be passed in as an enum. I didn't add thetextWrappingbreak type as that is the default break type and is already available as part of theRunclass.This is my first time submitting a non-trivial feature to this library, so let me know if there's anything to improve for next time to make the PR process quicker.
This makes it possible to generate column layouts like this (this is the output of the demo file I added):
