Create packer stream "toStream" #1636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this alias, JSZip throws a "nodestream not supported on this platform" error. This addition resolves the issue.
New Function returns a NodeJS readable stream that allows piping DOCX document data to stream.
|
This might break browser compatability, but lets see Edit: Need to fix build issues |
Codecov ReportBase: 99.61% // Head: 99.62% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1636 +/- ##
=======================================
Coverage 99.61% 99.62%
=======================================
Files 318 318
Lines 3681 3690 +9
Branches 396 396
=======================================
+ Hits 3667 3676 +9
Misses 14 14
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a new DOCX export function that returns a readable stream. I created this to help reduce memory needs when generating a document with a log of image files.
I had to update the webpack config file because JSZip was not detecting the NodeJS stream object during testing and threw errors for jszip.generateNodeStream() function.