-
-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Override levels impl #1823
Override levels impl #1823
Conversation
Merge latest changes from Dolans master (V7)
Upd to latest Dolan master
Update from Dolan's master
Upd to latest version of docx js
Breaking change
Wow, very nice Will review Regarding the tests, I believe it's because of nanoid, if that is downgraded, then tests should work I think |
Nanoid has critical vulnerability in the older versions, than 4. |
No it must be, because there is an open PR which only upgrades nanoid from 3 -> 4, and it broke: Take a look |
There is one broken test in the project |
Codecov ReportBase: 99.82% // Head: 99.82% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1823 +/- ##
=======================================
Coverage 99.82% 99.82%
=======================================
Files 317 317
Lines 3894 3896 +2
Branches 476 476
=======================================
+ Hits 3887 3889 +2
Misses 7 7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Amazing, merged thanks!! |
Bonjour :)
Finally got some time to take care of this.
Tell me the secret of running tests! :) Just after polling and
npm i
you cannot really runnpm test
I am getting
TypeError [ERR_UNKNOWN_FILE_EXTENSION]: Unknown file extension ".ts" for
Nevertheless I believe it should work.
I also fixed and added additional tests to this breaking change improvements.
This pull request is related to this issue: #1740