Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1699 Allow images to work with Hyperlink #1853

Merged
merged 2 commits into from
Dec 26, 2022
Merged

Conversation

dolanmiu
Copy link
Owner

@dolanmiu dolanmiu commented Dec 26, 2022

Fixes #1699

Add stack to IContext for prepForXml

Add stack to IContext for prepForXml
@codecov-commenter
Copy link

codecov-commenter commented Dec 26, 2022

Codecov Report

Base: 99.82% // Head: 99.82% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (69bf313) compared to base (abcfd79).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1853   +/-   ##
=======================================
  Coverage   99.82%   99.82%           
=======================================
  Files         319      320    +1     
  Lines        3980     4009   +29     
  Branches      553      559    +6     
=======================================
+ Hits         3973     4002   +29     
  Misses          7        7           
Impacted Files Coverage Δ
src/export/packer/next-compiler.ts 100.00% <ø> (ø)
src/file/xml-components/base.ts 100.00% <ø> (ø)
src/export/formatter.ts 100.00% <100.00%> (ø)
.../drawing/doc-properties/doc-properties-children.ts 100.00% <100.00%> (ø)
src/file/drawing/doc-properties/doc-properties.ts 100.00% <100.00%> (ø)
...ies/non-visual-properties/non-visual-properties.ts 100.00% <100.00%> (ø)
src/file/xml-components/default-attributes.ts 100.00% <100.00%> (ø)
src/file/xml-components/xml-component.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dolanmiu dolanmiu merged commit 5907132 into master Dec 26, 2022
@dolanmiu dolanmiu deleted the feat/hyperlink-images branch December 26, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ExternalHyperLink not working with images
2 participants