Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vite build issues #2244

Merged
merged 4 commits into from
Jul 19, 2023
Merged

Fix vite build issues #2244

merged 4 commits into from
Jul 19, 2023

Conversation

dolanmiu
Copy link
Owner

Fixes #2222

@dolanmiu dolanmiu mentioned this pull request Jul 18, 2023
Closed
@dolanmiu dolanmiu merged commit 2ab06ff into master Jul 19, 2023
@dolanmiu dolanmiu deleted the feature/build-fixes branch July 19, 2023 00:19
@Volper212
Copy link

That's a breaking change, isn't it?

@dolanmiu
Copy link
Owner Author

dolanmiu commented Aug 2, 2023

No it's not

Tested it on:

Node
Regular html - iife
React
Angular

All fine

And the buffer change was intentional, it was Uint8Array before anyway, so now it is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Packer.toBuffer() returns a UInt8Array
2 participants
@dolanmiu @Volper212