Draft: Unbundle dependencies #2254
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of bundling all dependencies into docx's built JS (which is a common approach for browser environments), this lets them be imported through import / require (as is typical with NPM). This reduces the size of docx's builds from ~711kB each to ~250kB each and avoids duplicating code for applications that are already using dependencies such as jszip. It also avoids any Node.js polyfills, which is a mixed bag - that prevents problems such as dolanmiu#2237 but leaves it up to users to provide polyfills themselves if using a browser environment. Code for listing dependencies is based on https://stackoverflow.com/a/74578129/25507
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #2254 +/- ##
=======================================
Coverage 99.93% 99.93%
=======================================
Files 329 329
Lines 13149 13149
Branches 1365 1365
=======================================
Hits 13141 13141
Misses 8 8 ☔ View full report in Codecov by Sentry. |
|
What would happen to the https://www.unpkg.com/[email protected]/build/index.umd.js It needs to be bundled for https://github.com/dolanmiu/docx/blob/master/demo/browser-demo.html |
|
Yeah thought so:
Anyway to fix this you think? |
|
Closing this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of bundling all dependencies into docx's built JS (which is a common approach for browser environments), this lets them be imported through import / require (as is typical with NPM). This reduces the size of docx's builds from ~711kB each to ~250kB each and avoids duplicating code for applications that are already using dependencies such as jszip. It also avoids any Node.js polyfills, which is a mixed bag - that prevents problems such as #2237 but leaves it up to users to provide polyfills themselves if using a browser environment.
Code for listing dependencies is based on https://stackoverflow.com/a/74578129/25507