Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed default section margin from inch to Twip #2379

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

rahon6000
Copy link
Contributor

@rahon6000 rahon6000 commented Oct 12, 2023

Some wierd word editor cannot interpret imperial units from xml.

This may frustrate new comers, trying to execute samples and fail.

Thus I think default margin value for section should be written in Twip, if no other problems occur.

Also, MS word automatically changes inches into Twip when saving, which may justify this change.

Fixes #2327

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d5d8055) 99.93% compared to head (3a36d91) 99.93%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2379      +/-   ##
==========================================
- Coverage   99.93%   99.93%   -0.01%     
==========================================
  Files         329      329              
  Lines       13157    13156       -1     
  Branches     1365     1365              
==========================================
- Hits        13149    13148       -1     
  Misses          8        8              
Files Coverage Δ
...ment/body/section-properties/section-properties.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dolanmiu dolanmiu merged commit f9d1c19 into dolanmiu:master Oct 20, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unsupported type for pageMargin coordinates
2 participants