Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix page/thematic breaks #41

Merged
merged 2 commits into from
Sep 15, 2017
Merged

Fix page/thematic breaks #41

merged 2 commits into from
Sep 15, 2017

Conversation

jacwright
Copy link
Contributor

@jacwright jacwright commented Sep 15, 2017

These items are not paragraph properties, but part of the content of the paragraph.

I'm suggesting this fix, but I've not been able to build and test docx because of the error below, so please could you either direct me to how to get around the error or run the tests before merging?

ts/docx/xml-components/default-attributes.ts(20,32): error TS2536: Type 'string' cannot be used to index type 'AttributeMap<T>'.

These items are not paragraph properties, but part of the content of the paragraph.
@dolanmiu
Copy link
Owner

dolanmiu commented Sep 15, 2017

Yes you may have a point:
http://officeopenxml.com/WPtextSpecialContent-break.php
http://officeopenxml.com/WPparagraph.php

This is what it says in the docs:

<w:r>
    <w:t>This is</w:t>
        <w:br/>
    <w:t xml:space="preserve"> a simple sentence.</w:t>
</w:r>

@dolanmiu
Copy link
Owner

As for the test, I have to do some research,

i'll merge this in soon, after some digging around, as it seems this pull request is not related to this broken test

@dolanmiu
Copy link
Owner

Figured out the issue, because version ^2.4.1 of typescript broke it, as it used a newer version which had breaking changes.

I pinned it to 2.4.1 which fixed, merging your change now

Thanks!

@dolanmiu dolanmiu merged commit 58eca3f into dolanmiu:master Sep 15, 2017
@jacwright jacwright deleted the patch-1 branch September 15, 2017 14:58
@jacwright jacwright mentioned this pull request Sep 15, 2017
@dolanmiu
Copy link
Owner

Released 2.1.3 with this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants