GameINI: Fix tattoo texture saving in Rabbids Go Home

[duckymomo360]

Saving rabbid with EFB Copies to Texture Only:
Rabbid's texture is saved as fully black.

Saving rabbid without EFB Copies to Texture Only:
Intended behavior.

[JosJuice]

@JMC47 What do you think? Is this worth the performance impact, considering it's something you could toggle just when saving the Rabbid?

[Tilka]

The impact is small but some areas are already not running at full speed, at least not on my computer.

[JMC47]

This is one of those cases where I wish we had a Accuracy vs Performance INI option. I lean toward merging it, but I'm not sure.

[duckymomo360]

I've never noticed a performance impact in this game with this hack disabled, at least on my hardware.
I'd also like to add that people can actually put a lot of time/effort into customizing their rabbid (as dumb as that sounds), and there's absolutely no warning that all of your progress will be immediately erased as soon as you exit the editor if you're using default dolphin settings. It can be pretty upsetting for people unfamiliar with how the game behaves on dolphin.

[iwubcode]

Assuming I haven't reduced the performance benefits with GM2.0 then this is probably another one for #12156 when I can get back to it.. (adding to remind myself).

[JMC47]

I'm going to make an executive decision on this and say correct emulation is probably better than not in this case. While I get that it may not be necessary for any minigames, the customization is part of the game and this is a pretty major graphical issue when using the feature. I'm not going to say this is the standard for similar features in other games, but for now let's try this and see if people complain about the game's performance.

It's just as easy to tell people to turn it off for performance as it is to tell them to turn it on for correct emulation.

[JosJuice]

It's just as easy to tell people to turn it off for performance as it is to tell them to turn it on for correct emulation.

It's actually harder, because turning it off can be done using the global settings, whereas overriding the INI can't.

But we can go with what you said. Let's try it.

[JMC47]

I did think of that, but I still lean toward correct emulation, and telling users what setting changed. I did test this on Mali and (on an albeit strong phone) it seemed fine with EFB2RAM at 1x IR.