Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unicode support for Collection>>split: #1015

Closed
dram opened this issue Sep 14, 2020 · 0 comments
Closed

Unicode support for Collection>>split: #1015

dram opened this issue Sep 14, 2020 · 0 comments
Labels

Comments

@dram
Copy link

dram commented Sep 14, 2020

Describe the bug

Unicode support for Collection>>split: is broken, it will cause IntraCharacterInde error.

To Reproduce

Try following code to reproduce:

#($一 $二 $三) split: '1一2二3三'

Additional context

Following is full backtrace:

Utf8String(Object)>>error:
Utf8String(UtfEncodedString)>>errorIntraCharacterIndex:
Utf8String>>decodeAt:
Utf8String(UtfEncodedString)>>uncheckedFrom:to:keysAndValuesDo:
Utf8String(SequenceableCollection)>>from:to:keysAndValuesDo:
Utf8String(SequenceableCollection)>>from:keysAndValuesDo:
Array(Collection)>>_indexOfAnyInString:startingAt:
Utf8String(String)>>indexOfAnyOf:startingAt:
Array(Collection)>>split:
...
@dram dram added the bug label Sep 14, 2020
blairmcg added a commit that referenced this issue Sep 14, 2020
- Also fix inconsistent handling of trailing terminator, and allow empty
separators.
- Add test coverage.
blairmcg added a commit that referenced this issue Feb 25, 2021
blairmcg added a commit that referenced this issue Feb 25, 2021
blairmcg added a commit that referenced this issue Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant