Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve #1093: Optimization of Collection>>#distinct #1107

Merged
merged 1 commit into from
Feb 27, 2021

Conversation

blairmcg
Copy link
Contributor

As discussed in #1093, use Collection>>#approxSize to resize the collection
as it is intended for this kind of purpose, and is expected to have a
constant time implementation (i.e. it should not count the elements).

Collection>>#distinct is already adequately covered with unit tests

As discussed in #1093, use Collection>>#approxSize to resize the collection
as it is intended for this kind of purpose, and is expected to have a
constant time implementation (i.e. it should not count the elements).

Collection>>#distinct is already adequately covered with unit tests
@blairmcg blairmcg merged commit 6978769 into release/7.1 Feb 27, 2021
@blairmcg blairmcg deleted the blairmcg/1093 branch February 27, 2021 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant