Optimise comparison of ScaledDecimals #1120
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #1119, adds
equalToScaledDecimal:
double-dispatch handler in various ArithmeticValue subclasses.To optimise SmallInteger=ScaledDecimal comparisons I initially added an implementation of
=
to Integer (implemented as per the primitive fallback code inLargeInteger>>#=
) however this had a negative effect on SmallInteger=Float comparisons. Instead the performance of SmallInteger=ScaledDecimal comparisons has been improved by optimising Integer-ScaledDecimal subtractions - seeScaledDecimal>>#subtractFromInteger:
. ScaledDecimal creation has also been optimised slightly by use of primitive 157.Resolves #1119.