Command queries can be zero-arg testing methods #1207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All the C++ prims follow a style that conditional forward jumps are not taken except in the error case. This is because the default prediction for a forward jump is that it is not taken.
Many command queries do nothing other than set the enablement of the command, in which case the code is simpler and smaller if a command query method can be a simple testing method that takes no arguments and returns true if the command is to be enabled, or false if disabled. This seems to apply to the majority of cases visited so far, and in quite a few cases allows for the use of existing testing methods to be used, reducing the proliferation of individual query methods specific to individual commands or related groups of commands. Also perform some validation of the query annotations, since it is easy to make a small mistake, such as mispelling a selector, and end up breaking the command handling in the development tools. As the command queries are often called repeatedly as a background/idle task to revalidate the UI state (e.g. for toolbar buttons), this can cause repetitive errors that are at best annoying, and at worst terminal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many command queries do nothing other than set the enablement of the command, in which case the code is simpler and smaller if a command query method can be a simple testing method that takes no arguments and returns true if the command is to be enabled, or false if disabled.
This seems to apply to the majority of cases visited so far, and in quite a few cases allows for the use of existing testing methods to be used, reducing the proliferation of individual query methods specific to individual commands or related groups of commands.
Also perform some validation of the query annotations, since it is easy to make a small mistake, such as mispelling a selector, and end up breaking the command handling in the development tools. As the command queries are often called repeatedly as a background/idle task to revalidate the UI state (e.g. for toolbar buttons), this can cause repetitive errors that are at best annoying, and at worst terminal.
Replace old #queryCommand: methods in MoenTreeView, Card containers, collection presenters and workspace classes.