Improve ability to store legacy format (pre-namespace) packages #1218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Over the years a number of new bytecode optimisations have been added to the compiler, and in some cases these have introduced issues with the mapping of IPs from normal code to debug code that the debugger does when translating a stack frame to a debug frame. The problems appear to be a combination of incorrect management of the text maps in the compiler and the Debugger's ip remapping not handling some corner cases that are either new or have become more common. This work isn't finished yet, and hence there are still two versions of the mapping method. One in use, one under (incomplete) testing.
Revise STB to use a policy object to determine various aspects of the format that have changed over time. This allows us to handle variability when reading old versions in a more elegant manner, but more importantly allows us to write in the old format. This only works if the class format hasn't changed - we don't have the ability to write classes in old formats, only to respect the overall STB format for particular versions. This does however improve round-tripping with of packages between D7 and D8. All of the existing conversions were visited, and the test coverage of old versions improved where old binary serialisation data existed, or could be recreated. Existing view/presenter tests not under PresenterTest were moved there to be able to inherit the STB/STL conversion tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revise STB to use a policy object to determine various aspects of the format that have changed over time. This allows us to handle variability when reading old versions in a more elegant manner, but more importantly allows us to write in the old format. This only works if the class format hasn't changed - we don't have the ability to write classes in old formats, only to respect the overall STB format for particular versions. This does however improve round-tripping with of packages between D7 and D8.
All of the existing conversions were visited, and the test coverage of old versions improved where old binary serialisation data existed, or could be recreated. Existing view/presenter tests not under PresenterTest were moved there to be able to inherit the STB/STL conversion tests.