Move STB filer out of base package #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also make the STB version policy filer instance specific, rather than a flyweight with a single instance per version. This is neater as it reduces the amount of parameter passing, and also means that the classes are eligible for removal when deploying an image.
If a class defines a class constant that includes subclasses, then the class definition message will fail to compile unless the classes are predeclared. Fix the fact that the predeclaration mechanism is broken in D8, and ensure that it is tested by the PackageTests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also make the STB version policy filer instance specific, rather than a flyweight with a single instance per version. This is neater as it reduces the amount of parameter passing, and also means that the classes are eligible for removal when deploying an image.