Merge pull request #2450 from zippy1981/bugifix/2449-client-secret-wa…

…rnings Updated the comments around client secret.
domaindrivendev · Jul 13, 2022 · 39604d9 · 39604d9
2 parents 897ffed + f9e09be
commit 39604d9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/Swashbuckle.AspNetCore.SwaggerUI/SwaggerUIOptions.cs b/src/Swashbuckle.AspNetCore.SwaggerUI/SwaggerUIOptions.cs
@@ -192,6 +192,7 @@ public class OAuthConfigObject
         /// <summary>
         /// Default clientSecret
         /// </summary>
+        /// <remarks>Setting this exposes the client secrets in inline javascript in the swagger-ui generated html.</remarks>
         public string ClientSecret { get; set; } = null;
 
         /// <summary>

diff --git a/src/Swashbuckle.AspNetCore.SwaggerUI/SwaggerUIOptionsExtensions.cs b/src/Swashbuckle.AspNetCore.SwaggerUI/SwaggerUIOptionsExtensions.cs
@@ -236,8 +236,9 @@ public static void OAuthUsername(this SwaggerUIOptions options, string value)
         /// </summary>
         /// <param name="options"></param>
         /// <param name="value"></param>
+        /// <remarks>Setting this exposes the client secrets in inline javascript in the swagger-ui generated html.</remarks>
         public static void OAuthClientSecret(this SwaggerUIOptions options, string value)
-        {
+        { 
             options.OAuthConfigObject.ClientSecret = value;
         }