Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for enums when a JsonSerializerContext is used #2723

Closed
wants to merge 6 commits into from
Closed

Added support for enums when a JsonSerializerContext is used #2723

wants to merge 6 commits into from

Conversation

dougclutter
Copy link

  1. To make it clearer what Type caused a failure during generation, modified the GetDataContractFor to catch and report more details.
  2. Changed JsonConverterFunc(object value) to JsonConverterFunc(dynamic value) so that enums don't cause generation to throw a NotSupportedException when a TypeInfoResolver is used (e.g. - JsonSerializerContext).
  3. Added unit tests that have a TypeInfoResolver to demonstrate the fix.

resolves #2722

Doug Clutter added 6 commits October 5, 2023 15:11
Added try-catch to GetDataContractFor so we provide more information …
ff198e0 
…about the actual Type that was causing a generation failure.
Changed JsonConverterFunc to take a dynamic value instead of an objec…
c66abfb 
…t value. Doing this allows the use of enums when using a TypeInfoResolver (e.g. - JsonSerializerContext).
Updated unit test project to net7.0 because TypeInfoResolver was adde…
71877f7 
…d to this release.
Added unit tests that show JsonConverterFunc(object value) fails when…
b8d2ef8 
… a TypeInfoResolver is used. However, JsonConverterFunc(dynamic value) works.
Changed image used by appveyor from "Visual Studio 2019" to "Visual S…
1b4e040 
…tudio 2022" so .NET 7 would be available when running tests.
Removed empty test that I added but didn't need.
73e6144
Havunen added a commit to Havunen/DotSwashbuckle2 that referenced this pull request Feb 18, 2024
@Havunen
Porting test cases from domaindrivendev/Swashbuckle.AspNetCore#2723 for
e969743 
Havunen/DotSwashbuckle#3
Havunen added a commit to Havunen/DotSwashbuckle that referenced this pull request Feb 18, 2024
@Havunen
Porting test cases from domaindrivendev#2723 for #3 credits @dougclutter
ff74036
@martincostello
Copy link
Collaborator

Thanks for contributing - if you'd like to continue with this pull request, please rebase against the default branch to pick up our new CI.

@martincostello martincostello mentioned this pull request Apr 14, 2024
Closed
@jgarciadelanoceda
Copy link
Contributor

@dougclutter
I have just created a fix to #2920, the PR has just been merged and seen your PR it is just touching the same code I did with #2941. Could you review if this PR is still needed?

@dougclutter
Copy link
Author

I'm closing down this PR; I just don't have time to dive back into this. Sorry folks!

@dougclutter dougclutter deleted the add-support-for-enums-with-jsonserializercontext branch June 10, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Provide more details on Type hierarchy when generation fails
3 participants
@dougclutter @martincostello @jgarciadelanoceda