Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes nullability problems with dictionaries #3023

Merged
merged 13 commits into from
Aug 13, 2024
Merged

Fixes nullability problems with dictionaries #3023

merged 13 commits into from
Aug 13, 2024

Commits on Aug 12, 2024

  1. Support nullable value types as Dictionary values

    @ozziepeeps
    ozziepeeps committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    b69b2d4 View commit details
    Browse the repository at this point in the history

  2. Support things that implement IDictionary or IReadOnlyDictionary

    @ozziepeeps
    ozziepeeps committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    b301564 View commit details
    Browse the repository at this point in the history

  3. Renable test types for clarity

    @ozziepeeps
    ozziepeeps committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    fb87241 View commit details
    Browse the repository at this point in the history

  4. Rename test

    @ozziepeeps
    ozziepeeps committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    599afab View commit details
    Browse the repository at this point in the history

  5. Add tests over IDictionary

    @ozziepeeps
    ozziepeeps committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    cb1ad75 View commit details
    Browse the repository at this point in the history

  6. Add tests over IReadOnlyDictionary

    @ozziepeeps
    ozziepeeps committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    e55b76e View commit details
    Browse the repository at this point in the history

  7. Add new tests over Dictionary and variants with value type values

    @ozziepeeps
    ozziepeeps committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    7901ac0 View commit details
    Browse the repository at this point in the history

  8. Dictionary values should be value types

    @ozziepeeps
    ozziepeeps committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    f700cb2 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2024

  1. Suggestions from code review

    @ozziepeeps
    ozziepeeps committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    5dd8b54 View commit details
    Browse the repository at this point in the history

  2. More feedback from code review

    @ozziepeeps
    ozziepeeps committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    7d1732e View commit details
    Browse the repository at this point in the history

  3. Fix indenting

    @ozziepeeps
    ozziepeeps committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    68b084a View commit details
    Browse the repository at this point in the history

  4. Refactor with more comments to help folks in the future

    @ozziepeeps
    ozziepeeps committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    9984eff View commit details
    Browse the repository at this point in the history

  5. Clarify comment

    @ozziepeeps
    ozziepeeps committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    542c4ae View commit details
    Browse the repository at this point in the history