Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows switching of Quai and Qi coinbases based on MinerPreference flag #2215

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

Djadih
Copy link
Contributor

@Djadih Djadih commented Oct 10, 2024

No description provided.

@Djadih Djadih added the enhancement New feature or request label Oct 10, 2024
@Djadih Djadih added this to the GoldAge Testnet milestone Oct 10, 2024
@Djadih Djadih self-assigned this Oct 10, 2024
@Djadih Djadih marked this pull request as draft October 10, 2024 20:12
@wizeguyy wizeguyy marked this pull request as ready for review October 10, 2024 20:30
@Djadih
Copy link
Contributor Author

Djadih commented Oct 10, 2024

Refactoring so that it doesn't swap. Instead, primary and secondary will need to be renamed in the config file and we will just indicate preference via the flag.

wizeguyy
wizeguyy previously approved these changes Oct 11, 2024
@wizeguyy wizeguyy self-requested a review October 11, 2024 00:49
@wizeguyy wizeguyy dismissed their stale review October 11, 2024 00:50

hit the wrong button

@Djadih Djadih marked this pull request as draft October 11, 2024 16:47
@Djadih Djadih force-pushed the miner-preference branch 2 times, most recently from 5b13506 to 88e6da0 Compare October 11, 2024 20:43
@Djadih Djadih marked this pull request as ready for review October 11, 2024 20:43
cmd/utils/flags.go Outdated Show resolved Hide resolved
core/worker.go Outdated Show resolved Hide resolved
@Djadih
Copy link
Contributor Author

Djadih commented Oct 14, 2024

Testing:

  • MinerPreference unspecified (default = 0.5):
  • Quai: 504
  • Qi: 514
  • MinerPreference: 0.9
  • Quai: 154
  • Qi: 1213

@Djadih Djadih force-pushed the miner-preference branch 5 times, most recently from 4edab00 to f963298 Compare October 15, 2024 15:30
@Djadih Djadih merged commit 0efe089 into dominant-strategies:main Oct 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants