Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exchangerate #2222

Closed
wants to merge 17 commits into from
Closed

Exchangerate #2222

wants to merge 17 commits into from

Conversation

gameofpointers
Copy link
Contributor

No description provided.

gameofpointers
gameofpointers commented Oct 12, 2024
View reviewed changes
common/math/big.go Outdated Show resolved Hide resolved
gameofpointers
gameofpointers commented Oct 12, 2024
View reviewed changes
consensus/misc/rewards.go Outdated
// spaces = [{"K Qi": state["K Qi"], "K Quai": k_quai}, spaces[1]]
// return spaces
func CalculateKQuai(primeTerminus *types.WorkObject, header *types.WorkObjectHeader, beta0 *big.Int, beta1 *big.Int) *big.Int {
kQuai := new(big.Int).Set(primeTerminus.ExchangeRate()) // in Its
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can only calculate KQuai in Prime right? so its not prime terminus exchange rate, it should be the parent exchange rate

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

gameofpointers
gameofpointers commented Oct 12, 2024
View reviewed changes
consensus/misc/rewards.go Outdated
// return spaces
func CalculateKQuai(primeTerminus *types.WorkObject, header *types.WorkObjectHeader, beta0 *big.Int, beta1 *big.Int) *big.Int {
kQuai := new(big.Int).Set(primeTerminus.ExchangeRate()) // in Its
d2 := LogBig(header.Difficulty())
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we not need d1 here ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have it below, it would be nice to have this done based on the pseudo-code above, hard to follow otherwise, might be good to do it as part of clean up or think might be hard to debug as well

gameofpointers
gameofpointers commented Oct 12, 2024
View reviewed changes
core/worker.go Outdated Show resolved Hide resolved
gameofpointers
gameofpointers commented Oct 12, 2024
View reviewed changes
core/worker.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wizeguyy wizeguyy Awaiting requested review from wizeguyy wizeguyy is a code owner

@kiltsonfire kiltsonfire Awaiting requested review from kiltsonfire kiltsonfire is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gameofpointers @kiltsonfire