Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QE-12061 fix publish workflow #522

Merged
merged 12 commits into from
Aug 23, 2024
Merged

Conversation

ddl-cedricyoung
Copy link
Collaborator

@ddl-cedricyoung ddl-cedricyoung commented Aug 22, 2024

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: https://dominodatalab.atlassian.net/browse/QE-12061

What is the new behavior?

fixes permission on this currently non-public repo - see the only green cucu-publish-test in the PR timeline below.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@ddl-cedricyoung ddl-cedricyoung marked this pull request as ready for review August 23, 2024 15:48
@ddl-cedricyoung ddl-cedricyoung requested a review from a team as a code owner August 23, 2024 15:48
@ddl-cedricyoung ddl-cedricyoung enabled auto-merge (squash) August 23, 2024 15:51
Copy link
Contributor

@ddl-xin ddl-xin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ddl-cedricyoung ddl-cedricyoung merged commit 81c60de into main Aug 23, 2024
5 checks passed
@ddl-cedricyoung ddl-cedricyoung deleted the QE-12061-fix-publish-workflow branch August 23, 2024 16:03
@ddl-cedricyoung ddl-cedricyoung changed the title Qe 12061 fix publish workflow QE-12061 fix publish workflow Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants