[DOM-59086] Fix uploading Folder to Dataset on Windows #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddl-mmahmoud
approved these changes
Oct 9, 2024
7 tasks
ddl-mmahmoud
added a commit
that referenced
this pull request
Oct 9, 2024
### Link to JIRA [DOM-59086](https://dominodatalab.atlassian.net/browse/DOM-59086) ### What issue does this pull request solve? This increments the release version for 6.0.0 parity after inclusion of #207 ### What is the solution? _placeholder_ ### Testing Briefly describe how the change was tested. The purpose of this section is that a reviewer can identify a test gap, if any. _e.g. "I ran an upgrade from 4.2 to 4.6"._ - [ ] Unit test(s) ### Pull Request Reminders - [ ] Has the [changelog](https://github.com/dominodatalab/python-domino/blob/master/CHANGELOG.md) been updated - [ ] Has relevant documentation been updated? - [ ] Does the code follow [Python Style Guide] (https://black.readthedocs.io/en/stable/the_black_code_style/current_style.html) - [ ] Are the existing unit tests still passing? - [ ] Have new unit tests been added to cover any changes to the code? - [ ] Has the JIRA ticket(s) been linked above? ### References (optional)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to JIRA
DOM-59086
What issue does this pull request solve?
On Windows machines, filepaths contain
\separators whereas the upload endpoint expects Unix-style/separators. This results in files not being uploaded properly on Windows. This is fixed for upload files (PR: #203). But the issue remains for uploading folders.What is the solution?
Replace Windows-style separators with Unix-style ones when uploading content from a folder.
Testing
Created unit test and manual test for uploading a non-empty folder on a Windows machine to a Dataset.
Pull Request Reminders