Fix for partially read ultralight tag #64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my use case, I found it relatively common to be able to retrieve partial NDEF messages, for example a tag with a URI ndef record of
https://example.com
, would often be returned ashttp!I��⸮�⸮��⸮⸮���⸮���⸮
, due to reading uninitialized memory.It seems to happen due to:
MifareUltralight::read
calls theNdefMessage
constructor regardless of if themessageLength
is0
NdefMessage::NdefMessage
constructor containswhile (index <= numBytes)
- which does allow a partial NDEF message to be processed, even ifnumBytes
is 0.My fix is to not call the
NdefMessage
constructor if there was an error reading the message.It seems to make corrupted reads a thing of the past for me!