Change bottom up implementation #229
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inputs don't need to be sorted, but we have to change how the bottom up implementation populates the results array. We can also simplify some of the statements by: 1) removing the call to list when we create the list 'items', as there's no need for it; 2) initializing the list items with zeros; and 3) removing the if statement in the nested loop, since it's not necessary anymore because of donnemartin#2. We have to change the test too. We can't hardcode the labels to indices because they may be in a different position.
Range has to start at 1, otherwise, during the first row iteration, we're going to get values from the last row of table T (T[-1]).
We can simplify the insert method by removing the nested conditionals.
This reverts commit 37bb783.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inputs don't need to be sorted, but we have to change how the bottom up implementation populates the results array.
We can also simplify some of the statements by:
We have to change the test too. We can't hardcode the labels to indices because they may be in a different position.