-
Notifications
You must be signed in to change notification settings - Fork 46.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PDF Download #4
Comments
Hi @WillDignazio, interesting suggestion! Not sure how to do this, if anyone has any tips, please feel free to share. |
@donnemartin If you convert this to a Gitbook , it gives interfaces to download this as pdf, epub and etc. |
Yup, try Gitbook. Having this amazing piece in PDF would be great, and I would appreciate it a lot. |
@donnemartin Or you can also use Travis CI to generate the PDF automatically and upload it as a GitHub releases. I can try setting up an example in my fork and make a Pull Request this weekend. The idea is to use a utility named pandoc that can convert Markdown file to other format such as PDF. We can setup a Travis build by installing the required tool and dependencies for pandoc in order to read Markdown file and generate the PDF file. EDIT: Did a quick experiment using Travis CI. I successfully installed pandoc and its required dependencies. However, the build failed when pandoc tries to parse images that are included using Markdown Full build log can be viewed here. |
@addianto interesting approach, thanks for investigating it and reporting the results. @dumindu @FilipMiletic I'll try to free up and check out Gitbook, thanks for the suggestion. |
Thank you very much for the work, this is life changing information! |
@SuperAssassinNinja @anishshah44 I really appreciate the gesture! Please just donate to your favorite charity, thanks :) |
I continued my previous experiment on using pandoc to automate PDF generation. The tool still failed to generate the PDF file. The cause of error probably because the image files are linked from external source, i.e. from Imgur. Is it possible to locally host the images in the repository? @donnemartin If anyone interested, you can see the build log here. |
Did a quick other experiment using a Python module named The result is not quite right yet. Several images and tables are rendered incorrectly in the generated PDF document. See the example: https://imgur.com/a/SGdrK |
Thanks for the update @addianto. I think hosting images in the repo is do-able. Good to hear that I'd like to explore the Gitbook path when I free up and compare the PDF result to |
@WillDignazio I just used the Atom plugin "Markdown to PDF" and it did at Ok job. Too large a font size is the only issue I'm seeing. |
Hi @donnemartin, thanks for making such an informative guide. P.S. Topics shall be empty. Its just how the doc will look like, will have to add data to respective topics and/or create nested topics based on requirement. |
Hi @divyum, thanks for prototyping Gitbook! This does look easier to digest than the current README and exercise solutions. I'm not too familiar with Gitbook, it seems like I'd have to run Gitbook from my GitHub account so it auto-syncs with this repo? Edited for clarity. |
Here you are |
@donnemartin I tried auto-sync repo, the issue is that Gitbook merges complete README into a single topic which is like a single README in Gitbook :P. The only way I see is to manually move data into different topics. I also tried making gitbook from gitbook-cli but seems it just gives you a basic structure and not automatically makes topic for each section (see here). We can also follow this structure and keep sections in different markdown files. |
@canhlinh thanks for the PDF version! I updated the original post with a link to your comment. @divyum thanks for the additional info! I hope to free up soon to better evaluate/help with Gitbook. |
Would be great to have a PDF as a github "release" |
Similar to #207, we could have something like this:
but it's not perfect, it still needs some tweaking. |
I just generated the latest PDF here |
If we can add these under releases, things will be more visible and accessible to all :) |
I just opened a PR for this. Feedback would be greatly appreciated. 🤞🏽 🙏🏽 |
@canhlinh Could you please update the pdf? Thank you! |
Thanks for sharing this informative pdf, can you please provide us how did you done that, because we need other versions of different languages as you know. |
You can run https://github.com/donnemartin/system-design-primer/blob/master/generate-epub.sh to generate an ePub, which can be converted to a PDF. |
Latest README.pdf |
I'd love to be able to read this as a PDF, can a pdf generated per-commit be added to the repo?
EDIT: Or a script to generate a pdf?
Edit by donnemartin: Thanks to @canhlinh for making a PDF version of the repo as of March 28, 2017! We're looking into perhaps a Gitbook version of this repo which supports PDF downloads.
The text was updated successfully, but these errors were encountered: